Skip to content

fix e2b sandbox timeout #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions commit0/harness/execution_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,10 @@ def __init__(
files_to_collect=files_to_collect,
)

self.sb = Sandbox(timeout=timeout)
# in modal, we create a sandbox for each operation. this seems super slow.
# let's try having a single sandbox for multiple operations
# assume the sandbox needs to be alive for 30 operations
self.sb = Sandbox(timeout=timeout * 30)
self.sb.commands.run("curl -LsSf https://astral.sh/uv/install.sh | sh")

# setup sandbox env
Expand All @@ -268,14 +271,14 @@ def exec_run_with_timeout(self, command: str) -> tuple[str, bool, float]:

For now, we can just check if the sandbox is still alive.
"""
# TODO: setup timeout
start_time = time.time()
result = self.sb.commands.run(command, timeout=0)
# half-hour timeout per operation
result = self.sb.commands.run(command, timeout=self.timeout)
if self.files_to_collect is not None:
for fname in self.files_to_collect:
with (self.log_dir / fname).open("w") as f:
f.write(self.sb.files.read(f"testbed/{fname}"))
timed_out = self.sb.is_running()
timed_out = not self.sb.is_running()
end_time = time.time()
return result.stderr, timed_out, end_time - start_time

Expand Down