Improvements to fix the build

Move List dependencies to same file as removes the story danger requirement.
Changes danger to use the package-lock
Updates the story reverence in the dangerfile
Update the github build script.

see #81

.github/workflows/build.yml

@@ -35,8 +35,9 @@ jobs:
         run: npm run lint
 
       - name: Danger
-        run: npm run danger -- ci
+        run: npm run danger:pr -- ci
         env:
+          PR: ${{ github.event.number }}
           DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Test

dangerfile.lite.ts

@@ -13,14 +13,16 @@ const allFiles = [...modifiedFiles, ...newFiles]
 
 // Keep lockfile up to date
 const packageChanged = includes(modifiedFiles, 'package.json')
-const lockfileChanged = includes(modifiedFiles, 'yarn.lock')
+const lockfileChanged = includes(modifiedFiles, 'package-lock.json')
 if (packageChanged && !lockfileChanged) {
-  const message = 'Changes were made to package.json, but not to yarn.lock'
+  const message =
+    'Changes were made to package.json, but not to package-lock.json'
   const idea = 'Perhaps you need to run `yarn install` or commit the lockfile?'
   warn(`${message} - <i>${idea}</i>`)
 }
 if (!packageChanged && lockfileChanged) {
-  const message = 'Changes were made to yarn.lock, but not to package.json'
+  const message =
+    'Changes were made to package-lock.json, but not to package.json'
   const idea = 'Perhaps you need to commit the package.json?'
   warn(`${message} - <i>${idea}</i>`)
 }
@@ -35,7 +37,7 @@ if (hasSrcChanges && !hasStoriesChanges) {
   )
 }
 
-const storiesFolderPath = 'stories/components'
+const storiesFolderPath = 'src/components'
 const hasStories = (folderName) =>
   fs
     .readdirSync(path.join(storiesFolderPath, folderName))

package.json

@@ -36,7 +36,7 @@
     "format": "prettier --write '**/{src,test,stories}/**/{*.js,*.ts,*.tsx,*.json,*.md,*.mdx}' example/index.tsx",
     "deploy-storybook": "storybook-to-ghpages",
     "danger:local": "danger local -b main --dangerfile dangerfile.lite.ts",
-    "danger:pr": "cross-env DANGER_GITHUB_API_TOKEN=${GITHUB_TOKEN} danger pr https://github.com/commitd/components/pull/${PR}"
+    "danger:pr": "danger pr https://github.com/commitd/components/pull/${PR}"
   },
   "peerDependencies": {
     "react": "^16.8.0 || ^17.0.0"

src/components/Icons/Icons.stories.tsx

@@ -0,0 +1,31 @@
+import { Meta, Story } from '@storybook/react'
+import React from 'react'
+import { Flex, SvgIcon } from '..'
+import { Copy, usePortalled } from '../../docs/util'
+import * as Icons from './'
+
+export default {
+  title: 'Components/Icons',
+  component: SvgIcon,
+} as Meta
+
+export const Default: Story = (_args, context) => {
+  const portalled = usePortalled(context)
+  const icons = Object.keys(Icons).filter((name) => /[A-Z]/.test(name[0]))
+  return (
+    <Flex css={{ flexWrap: 'wrap' }}>
+      {icons.map((key) => {
+        return (
+          <Copy
+            css={{ color: '$text' }}
+            portalled={portalled}
+            key={key}
+            content={key}
+          >
+            {React.createElement((Icons as Record<string, React.FC>)[key])}
+          </Copy>
+        )
+      })}
+    </Flex>
+  )
+}

src/components/List/List.stories.tsx

@@ -1,15 +1,13 @@
 import React from 'react'
 import { Meta } from '@storybook/react'
-import { List } from '.'
 import {
-  Box,
-  Button,
-  Flex,
+  List,
   ListItem,
   ListItemIcon,
   ListItemSecondaryAction,
   ListItemText,
-} from '..'
+} from '.'
+import { Box, Button, Flex } from '..'
 
 import { Check } from '../Icons'
 

src/components/List/index.ts

@@ -1 +1,5 @@
 export * from './List'
+export * from './ListItem'
+export * from './ListItemIcon'
+export * from './ListItemSecondaryAction'
+export * from './ListItemText'

src/components/SvgIcon/SvgIcon.stories.tsx

@@ -1,32 +1,14 @@
 import { Meta, Story } from '@storybook/react'
 import React from 'react'
 import { SvgIcon } from '.'
-import { Flex } from '..'
-import { Copy, usePortalled } from '../../docs/util'
-import * as Icons from '../Icons'
 
 export default {
-  title: 'Components/Icons',
+  title: 'Components/SvgIcon',
   component: SvgIcon,
 } as Meta
 
-export const Default: Story = (_args, context) => {
-  const portalled = usePortalled(context)
-  const icons = Object.keys(Icons).filter((name) => /[A-Z]/.test(name[0]))
-  return (
-    <Flex css={{ flexWrap: 'wrap' }}>
-      {icons.map((key) => {
-        return (
-          <Copy
-            css={{ color: '$text' }}
-            portalled={portalled}
-            key={key}
-            content={key}
-          >
-            {React.createElement((Icons as Record<string, React.FC>)[key])}
-          </Copy>
-        )
-      })}
-    </Flex>
-  )
-}
+export const Default: Story = (args) => (
+  <SvgIcon {...args}>
+    <path d="M9,20.42L2.79,14.21L5.62,11.38L9,14.77L18.88,4.88L21.71,7.71L9,20.42Z" />
+  </SvgIcon>
+)

src/components/index.ts

@@ -15,10 +15,6 @@ export * from './Icons'
 export * from './Input'
 export * from './Link'
 export * from './List'
-export * from './ListItem'
-export * from './ListItemIcon'
-export * from './ListItemSecondaryAction'
-export * from './ListItemText'
 export * from './RadioGroup'
 export * from './Slider'
 export * from './Subheading'