Skip to content

feat(select): fixes select behaviour when multiple instances #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

stuarthendren
Copy link
Contributor

the issue of multiple selects not closing properly, (done by setting the pointer event to none)

  • Adds correct display text to the input when user select a value
  • Separates placeholder and menu header as two props
  • Adds some stories as test cases for the issues

fix #236

the issue of multiple selects not closing properly, Adds correct display text to the input.

fix #236
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.8% 82.8% Coverage
0.0% 0.0% Duplication

@stuarthendren stuarthendren merged commit 1a57fd7 into main Nov 23, 2021
@stuarthendren stuarthendren deleted the stuarthendren/select branch November 23, 2021 11:01
@commitd-bot
Copy link
Contributor

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select issues
3 participants