Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with ThemeProvider and Badge #328

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Fixes issue with ThemeProvider and Badge #328

merged 1 commit into from
Nov 18, 2023

Conversation

stuarthendren
Copy link
Contributor

Corrects login in ThemeProvider to stop incorrect removal of theme class Simplifies the typing in Badge, it was correct but ts caused errors, so simplified.

What is the purpose of this pull request? (put an "X" next to item)

[ ] Bug fix
[ ] Enhancement
[ ] Documentation
[ ] Deployment
[ ] Process (e.g. improve continuous integration)
[ ] Other, please explain:

Which issue (if any) does this pull request address?

Fixes

What changes did you make?

Is there anything you'd like reviewers to focus on?

Corrects login in ThemeProvider to stop incorrect removal of theme class
Simplifies the typing in Badge, it was correct but ts caused errors, so simplified.
Copy link

changeset-bot bot commented Nov 18, 2023

🦋 Changeset detected

Latest commit: 2b55598

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@committed/ds Patch
@committed/ds-next Patch
@committed/ds-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stuarthendren stuarthendren merged commit 1f2c098 into beta Nov 18, 2023
1 check passed
@stuarthendren stuarthendren deleted the sh-theme branch November 18, 2023 11:26
@github-actions github-actions bot mentioned this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant