Skip to content

feat(usemergedrefs): add a hook to merge refs #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export * from './useHover'
export * from './useInterval'
export * from './useKeyboard'
export * from './useLocalState'
export * from './useMergedRefs'
export * from './useModal'
export * from './usePoll'
export * from './useTimeout'
Expand Down
1 change: 1 addition & 0 deletions src/useMergedRefs/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './useMergedRefs'
85 changes: 85 additions & 0 deletions src/useMergedRefs/useMergedRefs.stories.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
import { Column, Input, Text } from '@committed/components'
import { Meta, Story } from '@storybook/react'
import React, { useRef } from 'react'
import { useBoolean, useHover, useKeyboard } from '../'
import { useMergedRefs } from './useMergedRefs'

export interface UseMergedRefsDocsProps<T> {
/** spread array of refs to be merged, T extends `HTMLElement` */
refs?: Array<
React.RefCallback<T> | React.MutableRefObject<T> | undefined | null
>
}

/**
* useMergedRefs merges the passed refs into a single memoized ref function.
*
* ```ts
* const ExampleComponent = React.forwardRef((props, forwardedRef) => {
* const ref = React.useRef();
* return <div {...props} ref={useMergeRefs(ref, forwardedRef)} />;
* });
* ```
*
* @param refs spread array of refs to be merged
*/
export const UseMergedRefsDocs = <T extends HTMLElement>(
props: UseMergedRefsDocsProps<T>
) => null

export default {
title: 'Hooks/useMergedRefs',
component: UseMergedRefsDocs,
excludeStories: ['UseMergedRefsDocs'],
} as Meta

const ExampleComponent = React.forwardRef<HTMLInputElement>(
(props, forwardedRef) => {
const internalRef = React.useRef<HTMLInputElement>(null)
const [isHovered] = useHover(internalRef)
const mergedRef = useMergedRefs<HTMLInputElement>(forwardedRef, internalRef)

return (
<Input
css={{
color: isHovered ? '$primary' : '$primaryContrast',
}}
ref={mergedRef}
/>
)
}
)

const Template: Story = () => {
// const ExampleComponent = React.forwardRef<HTMLInputElement>(
// (props, forwardedRef) => {
// const internalRef = React.useRef<HTMLInputElement>(null)
// const [isHovered] = useHover(internalRef)
// const mergedRef = useMergedRefs<HTMLInputElement>(forwardedRef, internalRef)
//
// return (
// <Input
// css={{
// color: isHovered ? '$primary' : '$primaryContrast',
// }}
// ref={mergedRef}
// />
// )
// }
// )

const externalRef = useRef<HTMLInputElement>(null)

const [typing, { setTrue, setFalse }] = useBoolean(false)
useKeyboard('', setFalse, { event: 'keyup', element: externalRef })
useKeyboard('', setTrue, { event: 'keydown', element: externalRef })

return (
<Column gap>
<ExampleComponent ref={externalRef} />
<Text>{typing ? 'Typing...' : ``}</Text>
</Column>
)
}

export const Default = Template.bind({})
40 changes: 40 additions & 0 deletions src/useMergedRefs/useMergedRefs.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import { renderHook } from '@testing-library/react-hooks'
import React from 'react'
import { useMergedRefs } from '.'

test('Should provide initial null', () => {
const { result: first } = renderHook(() => useMergedRefs())
expect(first.current).toBeNull()
})
test('Should be null if all supplied null', () => {
const { result: first } = renderHook(() => useMergedRefs(null, null))
expect(first.current).toBeNull()
})

test('useMergedRefs should merge the refs', () => {
const testVal = true
const refAsFunc = jest.fn()
const refAsObj = { current: undefined }

const { result: first } = renderHook(() => useMergedRefs(refAsFunc, refAsObj))
expect(first.current).not.toBeNull()

first.current?.(testVal)

expect(refAsFunc).toHaveBeenCalledTimes(1)
expect(refAsFunc).toHaveBeenCalledWith(testVal)
expect(refAsObj.current).toBe(testVal)
})

test('useMergedRefs should not fail if invalid values', () => {
const refAsInvalid = { invalid: undefined }

const { result: first } = renderHook(() =>
useMergedRefs(null, (refAsInvalid as unknown) as React.Ref<string>)
)
// Would be valid if null here
expect(first.current).not.toBeNull()

// should not throw
first.current?.('testVal')
})
39 changes: 39 additions & 0 deletions src/useMergedRefs/useMergedRefs.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import React, { useMemo } from 'react'

type Ref<T> =
| React.RefCallback<T | null>
| React.MutableRefObject<T | null>
| undefined
| null

/**
* useMergedRefs merges the passed refs into a single memoized ref function.
*
* ```ts
* const ExampleComponent = React.forwardRef((props, forwardedRef) => {
* const ref = React.useRef();
* return <div {...props} ref={useMergeRefs(ref, forwardedRef)} />;
* });
* ```
*
* @param refs spread array of refs to be merged
*/
export function useMergedRefs<T>(
...refs: Ref<T>[]
): React.RefCallback<T> | null {
return useMemo(() => {
if (refs.every((ref) => ref == null)) {
return null
}
return (value: T) => {
refs.forEach((ref) => {
if (typeof ref === 'function') {
ref(value)
} else if (ref != null && 'current' in ref) {
ref.current = value
}
})
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, refs)
}