Skip to content

fix(usepagination): corrects behaviour of the queryCallback feature #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fix(usepagination): corrects behaviour of the queryCallback feature #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/usePagination/usePagination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useCallback, useEffect, useMemo, useState } from 'react'
import { useCallback, useEffect, useMemo, useRef, useState } from 'react'

export interface PaginationData {
/** The current page */
Expand Down Expand Up @@ -100,8 +100,16 @@ export function usePagination<T = void>({
setPageInternal((page) => Math.max(1, Math.min(page, totalPages)))
}, [totalPages])

const savedCallback = useRef<(data: PaginationData) => T>(queryCallback)

// Remember the latest callback.
useEffect(() => {
savedCallback.current = queryCallback
}, [queryCallback])

const query = useMemo(() => {
return queryCallback({
const callback = savedCallback.current
return callback({
page,
pageSize,
totalPages,
Expand All @@ -111,7 +119,6 @@ export function usePagination<T = void>({
isPreviousDisabled,
})
}, [
queryCallback,
page,
pageSize,
totalPages,
Expand Down