fix(usepagination): corrects behaviour of the queryCallback feature #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously used useMemo to protect the callback from change but this doesn't work for standard usage as the passed call back will be recreted for each render causein further rerenders. Now uses useRef to stop this loop but still allw the value to be chnaged.
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 0.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously used useMemo to protect the callback from change but this doesn't work for standard usage as the passed call back will be recreated for each render causing further re-renders. Now uses useRef to stop this loop but still allow the value to be changed.