Skip to content

check_consistency has no effect #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
obrus-corcentric opened this issue Dec 7, 2022 · 0 comments
Closed

check_consistency has no effect #53

obrus-corcentric opened this issue Dec 7, 2022 · 0 comments

Comments

@obrus-corcentric
Copy link

obrus-corcentric commented Dec 7, 2022

Hello, new option check_consistency has no any effect and command still called with --check-consistency option

Example of github action call:

      - id: cz
        name: Bump version and changelog
        uses: commitizen-tools/commitizen-action@master
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          dry_run: false
          push: false
          merge: false
          check_consistency: false

cz command call was:

cz --no-raise 21 bump --yes --changelog --check-consistency
@woile woile closed this as completed in 8eb5841 Jan 7, 2023
woile pushed a commit that referenced this issue Jan 7, 2023
fix: check_consistency beign ignored

Add input for GPG key and passphrase and whether or not to sign.

Add `-s` to `bump` command if `gpg_sign` is 'true'.

Set `gpg.program`, `commit.gpgsign`, and `tag.gpgsign`.

Git requires `signingkey` to sign commits and tags.

feat(debug): add option for debug output

Git takes the UID for the signing key, not the key itself.

Add `gpg.program` to Git config.

Use bash script to configure the GPG agent, import keys, set the
passphrase, and configure Git.

Use `service` as `systemctl` is not on GitHub Actions runners.

This reverts commit 2cf68aa.

This reverts commit a1c8571.

This reverts commit 94d316f.

Only sign tags. It may be that `commitizen` only supports signing tags.

See: commitizen-tools/commitizen#616

Remove `tag.gpgsign` and `commit.gpgsign` from local Git config.

See if Git will sign for us instead of through `cz`.

Remove specifying `gpg.program` and add `commit.gpgsign` back.

Add `--gpg-sign` back to `commitizen`.

Switch `--gpg-sign` applies to `bump` subcommand.

Move `--debug` switch to after `bump` command.

This reverts commit e543aff.

This reverts commit 3b2cae5.

Closes: #50

Closes: #53

Co-authored-by: Hendry, Adam <adam.hendry@metronic.com>
woile pushed a commit that referenced this issue Jan 7, 2023
fix: check_consistency flag being ignored

Add input for GPG key and passphrase and whether or not to sign.

Add `-s` to `bump` command if `gpg_sign` is 'true'.

Set `gpg.program`, `commit.gpgsign`, and `tag.gpgsign`.

Git requires `signingkey` to sign commits and tags.

feat(debug): add option for debug output

Git takes the UID for the signing key, not the key itself.

Add `gpg.program` to Git config.

Use bash script to configure the GPG agent, import keys, set the
passphrase, and configure Git.

Use `service` as `systemctl` is not on GitHub Actions runners.

This reverts commit 2cf68aa.

This reverts commit a1c8571.

This reverts commit 94d316f.

Only sign tags. It may be that `commitizen` only supports signing tags.

See: commitizen-tools/commitizen#616

Remove `tag.gpgsign` and `commit.gpgsign` from local Git config.

See if Git will sign for us instead of through `cz`.

Remove specifying `gpg.program` and add `commit.gpgsign` back.

Add `--gpg-sign` back to `commitizen`.

Switch `--gpg-sign` applies to `bump` subcommand.

Move `--debug` switch to after `bump` command.

This reverts commit e543aff.

This reverts commit 3b2cae5.

Closes: #50

Closes: #53

Co-authored-by: Hendry, Adam <adam.hendry@metronic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant