Skip to content

Add GPG Signing Support #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jan 7, 2023
Merged

Conversation

adam-grant-hendry
Copy link
Contributor

Adds support for GPG signing.

Closes: #50

Hendry, Adam added 2 commits October 24, 2022 09:03
Add input for GPG key and passphrase and whether or not to sign.
Add `-s` to `bump` command if `gpg_sign` is 'true'.
@adam-grant-hendry
Copy link
Contributor Author

@woile Would you please kindly review? Thank you!

Hendry, Adam added 27 commits October 24, 2022 12:20
Set `gpg.program`, `commit.gpgsign`, and `tag.gpgsign`.
Git requires `signingkey` to sign commits and tags.
Git takes the UID for the signing key, not the key itself.
Add `gpg.program` to Git config.
Use bash script to configure the GPG agent, import keys, set the
passphrase, and configure Git.
Use `service` as `systemctl` is not on GitHub Actions runners.
Only sign tags. It may be that `commitizen` only supports signing tags.

See: commitizen-tools/commitizen#616
Remove `tag.gpgsign` and `commit.gpgsign` from local Git config.
See if Git will sign for us instead of through `cz`.
Remove specifying `gpg.program` and add `commit.gpgsign` back.
Add `--gpg-sign` back to `commitizen`.
Switch `--gpg-sign` applies to `bump` subcommand.
Move `--debug` switch to after `bump` command.
Copy link
Member

@woile woile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woile woile merged commit 8eb5841 into commitizen-tools:master Jan 7, 2023
@woile
Copy link
Member

woile commented Jan 7, 2023

Sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: 🎉 Add Support for GPG Signing
2 participants