Skip to content

fix mypy warning and enforce it in scripts #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
Lee-W opened this issue Apr 8, 2020 · 3 comments
Closed
2 of 3 tasks

fix mypy warning and enforce it in scripts #153

Lee-W opened this issue Apr 8, 2020 · 3 comments
Assignees
Labels
type: feature A new enhacement proposal

Comments

@Lee-W
Copy link
Member

Lee-W commented Apr 8, 2020

After running mypy locally, I found there are type errors and even some logic errors. Since we already have type hint in our project, it seems to be better if we can fix them now.

Plan

  • Step 1. Fix current type error and logic errors
  • Step 2. Enforce mypy type check on GitHub Action
  • Step 3. Introduce a stricter mypy config and remove vague type like Any
@Lee-W
Copy link
Member Author

Lee-W commented Apr 24, 2020

Step 1 and 2 is done by #156

@Lee-W Lee-W removed the type: bug label Apr 24, 2020
@woile woile added type: feature A new enhacement proposal and removed enhancement labels Jul 24, 2020
@Lee-W Lee-W mentioned this issue Dec 8, 2021
4 tasks
woile added a commit that referenced this issue Apr 28, 2023
@woile woile mentioned this issue Apr 28, 2023
woile added a commit that referenced this issue Apr 28, 2023
@woile
Copy link
Member

woile commented Apr 28, 2023

mypy is strict enough I think, please reopen if otherwise

@woile woile closed this as completed Apr 28, 2023
@Lee-W
Copy link
Member Author

Lee-W commented May 6, 2023

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new enhacement proposal
Projects
None yet
Development

No branches or pull requests

2 participants