Skip to content

signed-off-by #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manang opened this issue Sep 29, 2021 · 14 comments
Closed

signed-off-by #438

manang opened this issue Sep 29, 2021 · 14 comments

Comments

@manang
Copy link
Contributor

manang commented Sep 29, 2021

This is not an issue, is there a way to add the signature to the commits?
I don't know if there is a way to force this option in git or cz.
Thanks a lot

Angelo

@manang
Copy link
Contributor Author

manang commented Sep 29, 2021

As workaround, is it possible to change this line

c = cmd.run(f"git commit {args} -F {f.name}")

git commit ... to
git c
in this way, configuring ~/.gitconfig, it is possible to create an alias for the commit command.
Thanks

@manang
Copy link
Contributor Author

manang commented Sep 29, 2021

pull request created #439

@Lee-W
Copy link
Member

Lee-W commented Sep 30, 2021

I think this is a duplicate one to #248

@manang
Copy link
Contributor Author

manang commented Sep 30, 2021

Can you check the pul request? Let me know if I can help on this feature.
Thanks

@Lee-W
Copy link
Member

Lee-W commented Sep 30, 2021

Yep, I'm now checking it 👍

@manang
Copy link
Contributor Author

manang commented Sep 30, 2021

a simple question:
how many time do you need to create the packages (pip + homebrew) after the merge of the pull request?
I need this info to understand if in my case I need to use a workaround.
Thank you very much

@Lee-W
Copy link
Member

Lee-W commented Oct 4, 2021

once it's been merge, it will be published automatically

@manang
Copy link
Contributor Author

manang commented Oct 5, 2021

news about the pr?

@Lee-W
Copy link
Member

Lee-W commented Oct 6, 2021

Hi, as this is a feature change, will need @woile 's approval to merge it.

@manang
Copy link
Contributor Author

manang commented Oct 6, 2021

ok, thanks.
let's wait @woile

Have a nice day:)

@manang
Copy link
Contributor Author

manang commented Oct 6, 2021

@woile
I've done a new commit, please, check it

Angelo

@manang
Copy link
Contributor Author

manang commented Oct 7, 2021

the action to publish the last release to brew does not work anymore.
can you check?
Thanks
@woile @Lee-W

@Lee-W
Copy link
Member

Lee-W commented Oct 9, 2021

the action to publish the last release to brew does not work anymore. can you check? Thanks

I've sent a pr to address this
#445

@manang manang closed this as completed Oct 13, 2021
@manang
Copy link
Contributor Author

manang commented Feb 17, 2022

#487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants