feat(commit): add retry_after_failure config option and --no-retry flag #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
+ Coverage 97.33% 97.48% +0.15%
==========================================
Files 42 55 +13
Lines 2104 2429 +325
==========================================
+ Hits 2048 2368 +320
- Misses 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…root returns None
…e for other retry test cases
woile
approved these changes
Mar 17, 2024
noirbizarre
approved these changes
Mar 19, 2024
noirbizarre
added
pr-status: ready-to-merge
Lee-W
approved these changes
Mar 30, 2024
commitizen/commands/commit.py
Outdated
| self.temp_file: str = get_backup_file_path() | ||
|
|
||
| def read_backup_message(self) -> str: | ||
| def read_backup_message(self) -> Optional[str]: |
There was a problem hiding this comment.
Suggested change
| def read_backup_message(self) -> Optional[str]: | |
| def read_backup_message(self) -> str | None: |
commitizen/commands/commit.py
Outdated
| import os | ||
| import tempfile | ||
|
|
||
| from typing import Optional |
There was a problem hiding this comment.
Suggested change
| from typing import Optional |
hooks/post-commit.py
Outdated
Comment on lines
7
to
8
| print("could not import commitizen:") | ||
| print(error) |
There was a problem hiding this comment.
Suggested change
| print("could not import commitizen:") | |
| print(error) | |
| print(f"could not import commitizen:\n{error}") |
commitizen/cz/utils.py
Outdated
Comment on lines
31
to
37
| return os.path.join( | ||
| tempfile.gettempdir(), | ||
| "cz.commit%{user}%{project}.backup".format( | ||
| user=os.environ.get("USER", ""), | ||
| project=project, | ||
| ), | ||
| ) |
There was a problem hiding this comment.
Suggested change
| return os.path.join( | |
| tempfile.gettempdir(), | |
| "cz.commit%{user}%{project}.backup".format( | |
| user=os.environ.get("USER", ""), | |
| project=project, | |
| ), | |
| ) | |
| user = os.environ.get("USER", "") | |
| return os.path.join( | |
| tempfile.gettempdir(), | |
| f"cz.commit%{user}%{project}.backup" | |
| ) |
|
Thanks so much for finishing this feature! I just fixed a few style-related nitpicks. Will merge this one once CI passes. |
|
Closes: #732 |
|
@Lee-W awesome, thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves #732 by implementing the requested feature.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
See #732 (comment).
Steps to Test This Pull Request
retry_after_failureAdditional context