fix(bump)!: only add version files and staged changes #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: VersionProvider has new method which will break any custom version provider
…version providers
marcusalstrom
requested review from
woile,
Lee-W and
noirbizarre
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4 #1261 +/- ##
=====================================
Coverage ? 97.64%
=====================================
Files ? 55
Lines ? 2594
Branches ? 0
=====================================
Hits ? 2533
Misses ? 61
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
As this is breaking change, I change the base branch to v4 |
Lee-W
reviewed
Nov 10, 2024
| @@ -34,6 +34,12 @@ def set_version(self, version: str): | |||
| Set the new current version | |||
| """ | |||
|
|
|||
| @abstractmethod | |||
| def get_files(self) -> list[str]: | |||
There was a problem hiding this comment.
maybe renamed as version_files would be better?
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
|
In general, I like this idea. @woile @noirbizarre would love to know your thought 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump will now only add and commit version files along with any already committed changes. Any unstaged changes will remain unstaged.
NOTE: BREAKING CHANGE, since we added a new abstract method to VersionProvider any custom version provider will break. (open to any suggestions on how to avoid this)
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Only version files and already staged changes will be committed on bump.
Steps to Test This Pull Request
Additional context
References issue #1194