Skip to content

docs(commit): add multiline option questions content table #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

ArneSchwerdt
Copy link
Contributor

@ArneSchwerdt ArneSchwerdt commented Oct 17, 2024

Description

I suggest to mention the multline support for input question in the documentation since it is already supported and a multiline description in the body is essential for good commits

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Question type = input and option multiline = True, multiline input is possible

Steps to Test This Pull Request

Additional context

Closes: #264

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.63%. Comparing base (120d514) to head (eea0eb4).
Report is 468 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
+ Coverage   97.33%   97.63%   +0.29%     
==========================================
  Files          42       55      +13     
  Lines        2104     2575     +471     
==========================================
+ Hits         2048     2514     +466     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.63% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit due to our existing style inconsistent. mostly looks good. plan to merge it these days

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels Oct 20, 2024
@Lee-W Lee-W force-pushed the docs/multiline-support branch from d105738 to eea0eb4 Compare October 23, 2024 01:42
@Lee-W Lee-W merged commit 2f6b7cc into commitizen-tools:master Oct 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiline commit messages when using a custom .cz.toml
2 participants