Skip to content

Conversation

@bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented May 24, 2025

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Expected Behavior

Steps to Test This Pull Request

Additional Context

@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (refactors@9420b44). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff              @@
##             refactors    #1453   +/-   ##
============================================
  Coverage             ?   97.62%           
============================================
  Files                ?       57           
  Lines                ?     2653           
  Branches             ?        0           
============================================
  Hits                 ?     2590           
  Misses               ?       63           
  Partials             ?        0           
Flag Coverage Δ
unittests 97.62% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism force-pushed the refactor-changelog-4 branch 3 times, most recently from 982859d to 42a86cc Compare May 24, 2025 08:31
@bearomorphism bearomorphism changed the title refactor(changelog): better typing, list comprehension refactor(changelog): better typing, yield May 24, 2025
@bearomorphism bearomorphism force-pushed the refactor-changelog-4 branch from 42a86cc to b1f4853 Compare May 25, 2025 14:41
@bearomorphism bearomorphism mentioned this pull request May 25, 2025
10 tasks
@bearomorphism bearomorphism force-pushed the refactor-changelog-4 branch from b1f4853 to 9e06722 Compare May 25, 2025 15:10
@Lee-W Lee-W changed the base branch from master to refactors May 26, 2025 01:31
@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels May 26, 2025
@Lee-W
Copy link
Member

Lee-W commented May 26, 2025

@woile @noirbizarre I'm happy about this change. I'm planning on merging this one this Wednesday, but would appreciate a second eye on this one 🙂

@Lee-W
Copy link
Member

Lee-W commented May 28, 2025

I'll go ahead an merge it 💪

@Lee-W Lee-W merged commit a3919c9 into commitizen-tools:refactors May 28, 2025
18 checks passed
@bearomorphism bearomorphism deleted the refactor-changelog-4 branch May 28, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants