Synchronize Pre-commit Hook Version with Commitizen Version #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of the Commitizen pre-commit hooks is typically bumped automatically by Commitizen itself, but because the behavior of cz bump was changed in Commitizen v2.32.3, and the bump from v2.32.2 to v2.32.3 was performed by Commitizen v2.32.2, the pre-commit hooks were not bumped.
The list of lines is now joined unconditionally in _bump_with_regex, so there is never a need to join it in update_version_in_files. The removed join was hence a no-op because it was performed on a str.
Codecov ReportBase: 98.43% // Head: 98.43% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 39 39
Lines 1596 1596
=======================================
Hits 1571 1571
Misses 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #579.
Bump pre-commit hook self test from v2.32.2 to v2.32.3. The version of the Commitizen pre-commit hooks is typically bumped automatically by Commitizen itself, but because the behavior of
cz bumpwas changed in Commitizen v2.32.3, and the bump from v2.32.2 to v2.32.3 was performed by Commitizen v2.32.2, the pre-commit hooks were not bumped.Remove a redundant join call. The list of lines is now joined unconditionally in
_bump_with_regex, so there is never a need to join it inupdate_version_in_files. The removedjoinwas hence a no-op because it was performed on astr.Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
cz bumpautomatically increments the version of the Commitizen pre-commit hooks.Steps to Test This Pull Request
cz bumplocally.Additional context
I should have split #568 into two separate pull requests; my apologies. As mentioned in #565, I am encountering some difficulties testing Commitizen locally.