Skip to content

Generate .cz.yaml that comply yamllint #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Generate .cz.yaml that comply yamllint #630

merged 4 commits into from
Jan 23, 2023

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Dec 3, 2022

Description

  • feat(yaml_config): add explicit_start for yaml output
  • ci(pre-commit): set linter and test stage to push stage
  • ci(scripts): add -nr 3 to commitizen commit check

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

cz init generates cz.yaml that complys yamllint

Steps to Test This Pull Request

  1. cz init
  2. choose .cz.yaml or cz.yaml
  3. install yamllint
  4. yamllint cz.yaml or yamllint .cz.yaml

Additional context

#618

@Lee-W Lee-W requested a review from woile December 3, 2022 08:28
@Lee-W Lee-W force-pushed the fix-cz-yaml-format branch from 02e6448 to 5c6907d Compare December 3, 2022 08:52
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Base: 97.92% // Head: 97.92% // No change to project coverage 👍

Coverage data is based on head (619e2d2) compared to base (db42a95).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 619e2d2 differs from pull request most recent head 0c807f3. Consider uploading reports for the commit 0c807f3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files          35       35           
  Lines        1252     1252           
=======================================
  Hits         1226     1226           
  Misses         26       26           
Flag Coverage Δ
unittests 97.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/changelog.py 98.86% <100.00%> (ø)
commitizen/config/yaml_config.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Lee-W added 4 commits January 23, 2023 19:33
when first creating a commit, there won't be any commit ahead of origin/master..
Thus, no commit to check error won't make sense in this case
generate cz.yaml that comply yamllint
@Lee-W Lee-W force-pushed the fix-cz-yaml-format branch from 619e2d2 to 0c807f3 Compare January 23, 2023 11:33
@Lee-W
Copy link
Member Author

Lee-W commented Jan 23, 2023

@woile I've rebased this one again. Could you please take a look when you have time? Thanks!

@woile woile merged commit 655efb1 into master Jan 23, 2023
@woile woile deleted the fix-cz-yaml-format branch January 23, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants