Skip to content

Relax specification for argcomplete dependency #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Relax specification for argcomplete dependency #680

merged 1 commit into from
Mar 8, 2023

Conversation

jakob-keller
Copy link
Contributor

Description

Similar to #589

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Allow for installation of argcomplete 2.1.x in commitizen enabled projects

Steps to Test This Pull Request

Additional context

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (48e9ce5) 98.02% compared to head (a60a9de) 98.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   98.02%   98.08%   +0.05%     
==========================================
  Files          40       40              
  Lines        1719     1720       +1     
==========================================
+ Hits         1685     1687       +2     
+ Misses         34       33       -1     
Flag Coverage Δ
unittests 98.08% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/hooks.py 95.65% <100.00%> (+0.19%) ⬆️
commitizen/changelog.py 100.00% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@woile woile merged commit fb0d1eb into commitizen-tools:master Mar 8, 2023
@jakob-keller jakob-keller deleted the argcomplete branch March 8, 2023 10:53
@nejch
Copy link

nejch commented Mar 11, 2023

Thanks for this @jakob-keller, @woile. 🙇 I guess this will be in the next release within a few weeks judging from the release cadence here.

In general, argcomplete seems to follow semver, would it make sense to relax this to v2 entirely? Not sure if it was intentional in 92b1e89 to restrict minor versions.

This sometimes gets installed in environments along with other dependencies so just to reduce the number of times we get conflicts.

nejch added a commit to python-gitlab/python-gitlab that referenced this pull request Mar 11, 2023
@jakob-keller
Copy link
Contributor Author

In general, argcomplete seems to follow semver, would it make sense to relax this to v2 entirely? Not sure if it was intentional in 92b1e89 to restrict minor versions.

This sometimes gets installed in environments along with other dependencies so just to reduce the number of times we get conflicts.

I agree. My intention here was to relax the restriction without questioning the generally restrictive way dependencies are specified in this repo. But this would be a great request, i.e. a separate issue IMO.

@nejch
Copy link

nejch commented Mar 11, 2023

Thanks @jakob-keller. I've opened #683, feel free to chime in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants