Skip to content

Enhance customization #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 20, 2019
Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Nov 19, 2019

  • add utils
    • required_validator
    • multiple_line_breaker
  • add jinja support for cz_customization

#6 , #24 , #54

@woile
Copy link
Member

woile commented Nov 19, 2019

Hey Lee please rebase and remove the extra commit.

git rebase -i origin/master

and add the option drop into the extra commit. Then continue normally the rebase.

@Lee-W Lee-W force-pushed the enhance-customization branch from adbefe1 to d44ade8 Compare November 19, 2019 18:38
@woile
Copy link
Member

woile commented Nov 19, 2019

I prefer not introducing dependencies like jinja. For me it's more than enough with from string import Template. I'd be willing to add jinja as an extra dependency.
In order to do so, you can install it doing poetry add jinja2 --optional
And then in the code:

try:
    from jinja2 import Template
except ImportError
    from string import Template

I think the interface of both templates is slightly different so it should be adjusted.

@Lee-W
Copy link
Member Author

Lee-W commented Nov 19, 2019

Yes, that makes sense to me. I've updated it.

@woile woile merged commit 9658c69 into commitizen-tools:master Nov 20, 2019
@Lee-W
Copy link
Member Author

Lee-W commented Nov 20, 2019

Should we close #6 , #24 , #54? Or, is there any other we should do on those issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants