-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove improvement #16
Conversation
@AndersDJohnson I do not think it is too late to remove improvement. Going forward in the future I believe exceptions can be made for the edge case commits that include the |
The good news is that it may not have spread too far: tools like |
I also came across this issue today when using |
@AndersDJohnson are there any blockers to moving forward with this change? |
@skeggse None other than making sure we have consensus and an admin taking the time to merge it! Almost ready? |
Yes! This is interfering with commits as |
Ditto |
Released and published as |
BREAKING CHANGE: Remove support for `improvement` prefix (as per commitizen/conventional-commit-types#16).
BREAKING CHANGE: Remove support for `improvement` prefix (as per commitizen/conventional-commit-types#16).
I'm proposing we consider removing the
improvement
type, which is no longer recommended in the Conventional Commits spec. It was in their1.0.0-beta.4
release, but removed in1.0.0
.It was added here in #13, as did other tools like conventional-changelog/commitlint#832. But this addition was questioned in #15, which I'd agreed with per my comments #13 (review) and #15 (comment).
This also caused some other turbulence with other tools, such as commitizen/cz-cli#681 and conventional-changelog/commitlint#832.
Maybe it's too late? 🤷♂