-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for staged commits before questionnaire #785
Comments
i might not be the right person to answer your direct question, but you can avoid needing to go through the wizard a second time in cases like this using the |
@travi NICE! That's a good workaround for now, but will still love to hear what others have to say. |
I agree with @waynevanson. As the CLI is able to know upfront that there's nothing staged, I don't see why it asks for information. I think it would be better to just send a message like "There's nothing staged! To commit, first stage something." Actually, I've just checked out the open issues and this one looks to be related to #585. Fixing that issue would resolve this one too. |
Check for staged files before running the prompt. Running the `git-cz` command with no files staged reports "No files added to staging". Preserve the functionality of `git -a` (--all) flag - `git-cz -a` command with no files added to staging area, adds all files to staging and opens the prompt (no error thrown). "fix commitizen#785"
Extend upon the existing staging unit tests. Assert that the files are added to staging area when running commitizen commit command with -a (--all) flag, prior to spawning the prompt. "re commitizen#785"
🎉 This issue has been resolved in version 4.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sometimes I forget to do
git add <path>
, so when I get to the end of the cli quesitonnaire, it gives me an error.I then have to do
git add <path>
and then run the cli, going through the questionnaire again.Doing this on a breaking change is frustrating because I have to rewrite what I just wrote.
Was this intended for a reason? If so, why? I'd like to hear about it.
The text was updated successfully, but these errors were encountered: