Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw better error when failing to parse json #304

Merged
merged 3 commits into from
Aug 3, 2016
Merged

fix: throw better error when failing to parse json #304

merged 3 commits into from
Aug 3, 2016

Conversation

marionebl
Copy link
Contributor

  • refactor getContent for clarity
  • annotate errors thrown by JSON.parse
  • cover getContent a bit better

Fixes #266

@marionebl marionebl force-pushed the fix/better-error-message-for-faulty-json branch from b20becc to 26f2369 Compare August 2, 2016 22:28
@LinusU
Copy link
Contributor

LinusU commented Aug 3, 2016

Nice! Thank you 👍

@LinusU LinusU merged commit 0d70197 into commitizen:master Aug 3, 2016
@marionebl marionebl deleted the fix/better-error-message-for-faulty-json branch August 3, 2016 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marionebl @LinusU