Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ node_js:
- '0.12'
before_install:
- git config --global user.name "TravisCI"
- git config --global user.email "commitizen@gmail.com"
- npm i -g npm@^2.0.0
before_script:
- npm prune
Expand Down
19 changes: 17 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,21 @@ to release new versions automatically.

* Commits of type `fix` will trigger bugfix releases, think `0.0.1`
* Commits of type `feat` will trigger feature releases, think `0.1.0`
* Commits with `BREAKING CHANGE` in body or footer will trigger breakgin releases, think `1.0.0`
* Commits with `BREAKING CHANGE` in body or footer will trigger breaking releases, think `1.0.0`

All other commit types wil trigger no new release.
All other commit types will trigger no new release.

## Gotchas

### Atom removes lines with just spaces, breaking tests

When using Atom, if you edit some of our tests, atom will remove the whitespace on some lines. Unfortunately we wanted this whitespace to
able to test multiline commits and their difference across operating
systems. Atom has decided to keep the stripping of whitespace as a
default. Although we understand this decision, it has the unfortunate
side effect of editing parts of the file that you might not have
intended. We think this should be left up to more configurable tools
like eslint.

For now, in order to work around this, you can take the steps outlined
[here](https://github.com/atom/whitespace/issues/10#issuecomment-85183781) to temporarily disable automatic whitespace removal in Atom.
3 changes: 2 additions & 1 deletion src/git/log.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {exec} from 'child_process';
import { exec } from 'child_process';

export { log };

Expand All @@ -11,6 +11,7 @@ function log(repoPath, done) {
cwd: repoPath
}, function(error, stdout, stderr) {
if (error) {
throw error;
done();
}
done(stdout);
Expand Down