Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): defined a github workflow to release with semantic-release #923

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

travi
Copy link
Contributor

@travi travi commented Apr 13, 2022

re-enables the release automation that was lost with the cleanup of the .travis.yml in #880. the GITHUB_TOKEN is provided automatically by the action and should have access to perform all necessary actions needed for the release. the NPM_PUBLISH_TOKEN would need to be made available as a secret to this action by a project maintainer.

this does not replace the verification that happens on Azure Pipelines and only runs on the master branch. it is assumed that changes are only ever merged after passing verification in a PR, so this workflow should be safe to implement independently from the existing verification pipelines.

this should unblock #914 and #897 (possibly more)

@daiyam
Copy link

daiyam commented Apr 18, 2022

@jimthedev @AndersDJohnson @kentcdodds Hi, could you validate this PR so a new release of the cli can be generated? Thx

@rin
Copy link

rin commented May 3, 2022

@LinusU @dmwelch Can you help? Thanks!

@micalevisk
Copy link

this PR will close the Issue #914 as the fix is merged already but not released yet

@travi
Copy link
Contributor Author

travi commented Jun 17, 2022

if adding me as a maintainer could help with details like this, i'd be willing to help out with basic maintenance tasks like this. i wouldnt be able to dedicate a lot of time due to other OSS project responsibilities (hopefully, my reputation on those projects helps build trust to consider me as a maintainer here), but would like to help unblock vulnerability issues like this.

@kdmcguire
Copy link

Adding another vote of support; @jimthedev, please consider @travi's offer! I'm sure plenty of repos (like mine) have got a Critical dependabot security alert because there hasn't been a release for commitizen despite the updates being merged in already.

@jimthedev
Copy link
Member

Just got back home. Wife has covid but will take a look and see if I can help.

@jimthedev
Copy link
Member

Secret added, going to merge this.

@jimthedev jimthedev merged commit 0939910 into commitizen:master Jul 17, 2022
@github-actions
Copy link

🎉 This PR is included in version 4.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@daiyam
Copy link

daiyam commented Jul 17, 2022

@jimthedev Thx

@jimthedev
Copy link
Member

@daiyam thank all of you for your patience.

@kdmcguire
Copy link

Thank you and @travi for resolving this!

@travi
Copy link
Contributor Author

travi commented Jul 17, 2022

thanks for the merge @jimthedev! feel free to let me know if you need more help. commitizen is super valuable in combination with semantic-release, so i'd be happy to pitch in a bit if i can help keep things going.

@travi travi deleted the release branch July 17, 2022 21:30
ryansonshine pushed a commit to ryansonshine/cz-cli that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants