feat(adapter): Load adapter from package.json if path provided has one #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the path provided for the adapter is a directory containing a package.json file, load the JS file specified in as the main value within that package.json file.
|
Whoops, didn't realize I had autoformatted a bunch of stuff too. Closing this and will reopen with just the changes I intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the path provided for the adapter is a directory containing a package.json file, load the JS file
specified in as the main value within that package.json file.
It seems like this would benefit from a test, but I'm not sure how best to approach that. I'd really love some input/guidance there.