Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adapter): Load adapter from package.json if path provided has one #97

Closed
wants to merge 1 commit into from

Conversation

colinrymer
Copy link

If the path provided for the adapter is a directory containing a package.json file, load the JS file
specified in as the main value within that package.json file.

If the path provided for the adapter is a directory containing a package.json file, load the JS file
specified in as the main value within that package.json file.
@colinrymer
Copy link
Author

Just wanted to bump this. I'm happy to write some tests for this, but not sure how best to approach them - would love some suggestions.

The rationale behind this PR is so I can dogfood an adapter I'm working on.

@colinrymer
Copy link
Author

Any chance we can get this merged or at least some feedback? https://www.npmjs.com/package/cz-pivotal-conventional-changelog won't work with the currently shipped version of cz-cli, because it ships with the code in a dist dir. Using a version of cz-cli with this patch, everything works just fine though.

@jimthedev
Copy link
Member

Hi @colinrymer I am trying to work to get caught up on PRs. There's been a lot going on and I'm sorry it has taken so long. I appreciate this PR but it unfortunately it directly conflicts this commit that landed recently. Essentially, the commit I linked to allows us to use a more standardized way to resolve modules. Can you take a look and see what changes would be needed in your PR so that we can accommodate cz-pivotal? Thanks.

@colinrymer
Copy link
Author

Definitely glad to resolve the conflict! I'll jump on that now.

@jimthedev
Copy link
Member

Really appreciate it
On Thu, Mar 3, 2016 at 3:11 PM Colin Rymer notifications@github.com wrote:

Definitely glad to resolve the conflict! I'll jump on that now.


Reply to this email directly or view it on GitHub
#97 (comment).

@colinrymer
Copy link
Author

Actually, we might be able to just close this PR. I was able to install v2.6.0 and everything seemed to work as expected re: the config. I did find an unrelated issue, but I'll open that as an actual issue.

@colinrymer colinrymer closed this Mar 3, 2016
@colinrymer colinrymer deleted the colinrymer-patch-1 branch March 3, 2016 21:27
@colinrymer
Copy link
Author

For the sake of convenience, posterity, etc., the issue I mentioned above is #153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants