-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): add support for custom types #114
Conversation
I realise this probably needs tests before it's accepted, but after looking at the test file, I unfortunately feel I that I don't have the time to do that right now. But since I forked the repo to add this functionality for our own use, I thought I could just as well open a PR and see what you thought. If the addition itself is welcomed, and only the lack of tests stops it from being merged, please tell me so, and I'll try to find the time to add those tests! |
Would be happy to merge if you want to rebase. There's no reason to not have both, correct? If someone wants to swap out all types that is type. If they want to add them then us additionalTypes? |
cd6a01d
to
1731a9e
Compare
This implementation does not overwrite all existing types.
Remove example from default values section, and add a separate example with description.
1731a9e
to
239d2c0
Compare
There we go. Rebased and ready. I also added a second commit updating the readme regarding |
@jimthedev Not sure you got a notification for my last message, so I thought I'd ping you 🙂 |
@adrianschmidt this seems like a change that'd be better upstream in cz-cli? Allow loading a .js file there, and then you can programmatically manipulate the types object & require conventional-commit-types. |
Hmm… yeah, that might be true. Sorry for not getting back to this earlier, I haven't had the peace of mind to sit down and look at it lately. I'll close this for now, and might come back with something for cz-cli later on. Thanks for your help! |
Inspired by #104, but slightly different implementation that doesn't require specifying all types just to add one or more custom ones.
The limitation in this implementation is that, while types defined in conventional-commit-types can be overridden, they cannot be removed entirely.
fix #93