Skip to content

Commit

Permalink
iio: adc: adrv9009: Prevent spurious interrupts during re-initialization
Browse files Browse the repository at this point in the history 
This fixes: ADRV9009 driver errors torvalds#343

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
  • Loading branch information
@mhennerich @commodo
mhennerich authored and commodo committed Jun 11, 2019
1 parent b1536a7 commit 2f641f6
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/iio/adc/adrv9009.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1102,7 +1102,9 @@ static int adrv9009_setup(struct adrv9009_rf_phy *phy)
}
}

disable_irq(phy->spi->irq);
ret = adrv9009_do_setup(phy);
enable_irq(phy->spi->irq);

phy->talInit.jesd204Settings.framerB.M = framer_b_m;
phy->talInit.jesd204Settings.framerB.F = framer_b_f;
Expand All @@ -1123,7 +1125,6 @@ static int adrv9009_multi_chip_sync(struct adrv9009_rf_phy *phy, int step)
switch (step) {
case 0:
TALISE_radioOff(phy->talDevice);
disable_irq(phy->spi->irq);
adrv9009_sysref_req(phy, SYSREF_CONT_OFF);

if (phy->is_initialized) {
Expand Down Expand Up @@ -1349,7 +1350,6 @@ static int adrv9009_multi_chip_sync(struct adrv9009_rf_phy *phy, int step)
}

TALISE_radioOn(phy->talDevice);
enable_irq(phy->spi->irq);
break;
default:
ret = -EINVAL;
Expand Down Expand Up @@ -1452,8 +1452,9 @@ static ssize_t adrv9009_phy_store(struct device *dev,
ret = kstrtol(buf, 10, &readin);
if (ret)
break;

disable_irq(phy->spi->irq);
ret = adrv9009_multi_chip_sync(phy, readin);
enable_irq(phy->spi->irq);
break;

default:
Expand Down

0 comments on commit 2f641f6

Please sign in to comment.