WIP: Add bash completion #721
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixes #579
Add some initial code to support bash completion following the guide here https://cli.urfave.org/v2/examples/bash-completions/
On Mac OS I install bash completion support using brew https://formulae.brew.sh/formula/bash-completion however this led me to an error with
nosortI followed this guide https://rakhesh.com/mac/bash-complete-nosort-invalid-option-name/ to identify the completions that were causing this issue.removing them from the folder made the error go away.
I'm on mac using bash 3.2
To get this working, we need to figure out exactly what the install steps and prerequisits are for bash complete to work on each platform and with which versions of bash.
We need to codify this, so thats generating the completion scripts and moving it to the correct location so that it gets loaded when bash starts.
In ZSH we had some extra behaviour for handling arguments and for assume, forcing no shell alias, this needs to be tested once we can get the completions to run in a dev environment.
Why?
How did you test it?
Potential risks
Is patch release candidate?
Link to relevant docs PRs