Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #29 The value of copyFrom.fetcher is not used in the LoadingOpt… #30

Closed

Conversation

bioflowy
Copy link

@bioflowy bioflowy commented Mar 3, 2024

…ions constructor

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 55.70%. Comparing base (0c14cfc) to head (97e5536).

Files Patch % Lines
src/test/LoadingOptions.spec.ts 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   55.62%   55.70%   +0.08%     
==========================================
  Files         127      128       +1     
  Lines        7837     7852      +15     
  Branches     1572     1572              
==========================================
+ Hits         4359     4374      +15     
- Misses       3111     3113       +2     
+ Partials      367      365       -2     
Flag Coverage Δ
unittests 55.70% <81.25%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bioflowy ; this repo is generated from another codebase, can you open a pull request against https://github.com/common-workflow-language/schema_salad/blob/main/schema_salad/typescript/util/LoadingOptions.ts ?

@bioflowy
Copy link
Author

bioflowy commented Mar 6, 2024

Thank you for your information. I will create a pull request for schema_salad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants