Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip $import: with a #local-ref; better handle $import and "run" references to parent directories #92

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

skip $import: with a #local-ref; better handle $import and "run" references to parent directories #92

wants to merge 13 commits into from

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Nov 15, 2021 •
edited
Loading

In response to the example in #69 (comment)

  • Needs a test

@codecov
Copy link

codecov bot commented Nov 15, 2021 •
edited
Loading

Codecov Report

Merging #92 (6d2ded9) into main (10fda17) will increase coverage by 1.82%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   75.37%   77.19%   +1.82%     
==========================================
  Files           4        5       +1     
  Lines         605      649      +44     
==========================================
+ Hits          456      501      +45     
+ Misses        149      148       -1
Files Changed Coverage Δ
cwlupgrader/main.py 73.04% <75.00%> (+1.10%) ⬆️
tests/test_complete.py 100.00% <100.00%> (ø)
tests/test_import.py 100.00% <100.00%> (ø)

@mr-c mr-c requested a review from tom-tan November 16, 2021 16:01
tom-tan
tom-tan suggested changes Nov 17, 2021
View reviewed changes
Copy link
Member

@tom-tan tom-tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add tests to show what is fixed or what kind of features are added in this request?
It makes easier to review the pull request.

@mr-c mr-c mentioned this pull request Dec 6, 2021
Closed
@mr-c
Copy link
Member Author

mr-c commented May 26, 2023

@tom-tan I added tests :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-tan tom-tan tom-tan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-c @tom-tan