Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load_document_by_uri method #345

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Fix load_document_by_uri method #345

merged 1 commit into from
Dec 25, 2024

Conversation

GlassOfWhiskey
Copy link
Collaborator

This commit adjusts the load_document_by_uri method, ensuring that the LoadingOptions object used to parse the document contains the correct values for fileuri and baseuri.

@GlassOfWhiskey GlassOfWhiskey marked this pull request as draft December 17, 2024 12:40
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.04%. Comparing base (3fbfa1b) to head (5e811ce).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cwl_utils/parser/__init__.py 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   33.85%   34.04%   +0.18%     
==========================================
  Files          30       30              
  Lines       35230    35237       +7     
  Branches     9467     9470       +3     
==========================================
+ Hits        11928    11995      +67     
+ Misses      20653    20598      -55     
+ Partials     2649     2644       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey force-pushed the fix-static-checker branch 2 times, most recently from 9359e56 to fab4251 Compare December 17, 2024 13:46
@GlassOfWhiskey GlassOfWhiskey requested a review from mr-c December 17, 2024 21:49
testdata/remote-cwl/tool1.cwl Show resolved Hide resolved
@GlassOfWhiskey GlassOfWhiskey marked this pull request as ready for review December 20, 2024 11:02
This commit adjusts the `load_document_by_uri` method, ensuring that the
`LoadingOptions` object used to parse the document contains the correct
values for `fileuri` and `baseuri`.
@mr-c mr-c force-pushed the fix-static-checker branch from 9ebc741 to 5e811ce Compare December 25, 2024 19:13
@mr-c mr-c enabled auto-merge (rebase) December 25, 2024 19:13
@mr-c mr-c merged commit 33a706b into main Dec 25, 2024
29 checks passed
@mr-c mr-c deleted the fix-static-checker branch December 25, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants