Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github actions workflow #325

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Added github actions workflow #325

merged 3 commits into from
Apr 15, 2021

Conversation

Anushka-shukla
Copy link
Contributor

@Anushka-shukla Anushka-shukla commented Apr 14, 2021

Fixes #318 Migrate from TravisCI to GitHub Actions

Description

We need to migrate from Travis CI to GitHub Actions

Motivation and Context

#318

How Has This Been Tested?

I created the GitHub actions workflow and checked it by running it on my forked repository, and it did pass all the checks.

Screenshots (if appropriate):

Screenshot from 2021-04-14 18-53-21

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So exciting, thank you!

I see an error in the logs

 Error:  Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project cwlviewer: Build error: Either repository token or service with job id must be defined -> [Help 1]

https://github.com/common-workflow-language/cwlviewer/runs/2343500160?check_suite_focus=true#step:9:10769

@mr-c
Copy link
Member

mr-c commented Apr 14, 2021

Can we name the workflow some different than .github/workflows/auto-merge.yml ? I don't think this workflow has anything to do with merging :-)

@mr-c
Copy link
Member

mr-c commented Apr 14, 2021

Can you also delete .travis.yml as part of this PR?

@mr-c
Copy link
Member

mr-c commented Apr 14, 2021

I edited the description to say "Fix #" and then the issue number so that merging this pull request will automatically close that issue :-)

@Anushka-shukla
Copy link
Contributor Author

Can we name the workflow some different than .github/workflows/auto-merge.yml ? I don't think this workflow has anything to do with merging :-)

Sure, can you suggest something?

@Anushka-shukla
Copy link
Contributor Author

Anushka-shukla commented Apr 14, 2021

So exciting, thank you!

I see an error in the logs

 Error:  Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project cwlviewer: Build error: Either repository token or service with job id must be defined -> [Help 1]

https://github.com/common-workflow-language/cwlviewer/runs/2343500160?check_suite_focus=true#step:9:10769

We have to add the Coverall authentication token to secrets of this repository, only after that, it will be able to upload the coverage report on Coveralls. More about adding secrets to here:https://docs.github.com/en/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-a-repository

@Anushka-shukla Anushka-shukla changed the title added github actions workflow Added github actions workflow Apr 14, 2021
- Removed travis.yml
- Updated README.md badge and target URL
- Updated pom.xml profile for CI

Fixes #318
@mr-c
Copy link
Member

mr-c commented Apr 15, 2021

So exciting, thank you!
I see an error in the logs

 Error:  Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project cwlviewer: Build error: Either repository token or service with job id must be defined -> [Help 1]

https://github.com/common-workflow-language/cwlviewer/runs/2343500160?check_suite_focus=true#step:9:10769

We have to add the Coverall authentication token to secrets of this repository, only after that, it will be able to upload the coverage report on Coveralls. More about adding secrets to here:https://docs.github.com/en/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-a-repository

Secrets are not available to GitHub Actions workflows running from a PR based upon a fork of the main repo where the secret is stored, except for GITHUB_TOKEN

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

https://docs.github.com/en/actions/reference/encrypted-secrets#using-encrypted-secrets-in-a-workflow

So as documented in trautonen/coveralls-maven-plugin#136 (comment) you can pass the GITHUB_TOKEN to -DrepoToken=; but please do so via environment variables (as documented there) so the token isn't printed in the log.

@Anushka-shukla
Copy link
Contributor Author

So exciting, thank you!
I see an error in the logs

 Error:  Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project cwlviewer: Build error: Either repository token or service with job id must be defined -> [Help 1]

https://github.com/common-workflow-language/cwlviewer/runs/2343500160?check_suite_focus=true#step:9:10769

We have to add the Coverall authentication token to secrets of this repository, only after that, it will be able to upload the coverage report on Coveralls. More about adding secrets to here:https://docs.github.com/en/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-a-repository

Secrets are not available to GitHub Actions workflows running from a PR based upon a fork of the main repo where the secret is stored, except for GITHUB_TOKEN

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

https://docs.github.com/en/actions/reference/encrypted-secrets#using-encrypted-secrets-in-a-workflow

So as documented in trautonen/coveralls-maven-plugin#136 (comment) you can pass the GITHUB_TOKEN to -DrepoToken=; but please do so via environment variables (as documented there) so the token isn't printed in the log.

Made the changes!

@Anushka-shukla Anushka-shukla marked this pull request as ready for review April 15, 2021 09:42
@mr-c mr-c self-requested a review April 15, 2021 09:55
@mr-c mr-c merged commit aaabd77 into common-workflow-language:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from TravisCI to GitHub Actions
2 participants