Optional codegen args #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alad into optional-codegen-args
This is because in the python codegen change we modified the order of the params to allow the optional to be (=None) and only optionally specified. With this change, the cwl-util tests pass
…alad into optional-codegen-args
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 69.60% 69.70% +0.09%
==========================================
Files 15 15
Lines 2820 2829 +9
Branches 738 743 +5
==========================================
+ Hits 1963 1972 +9
Misses 675 675
Partials 182 182
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopens #330
Thanks @mr-c for testing this in CWLUtils. Unfortunately the parameter reordering broke the parsing. I've added b9a30ff to address this problem by making
doc.loadto use kwargs (named arguments) instead of the original ordered arguments.I'll issue a CWL-utils PR with the updated generated code and hopefully travis will pass these to show this fix.