Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow $schemas in codegen #346

Merged
merged 10 commits into from
Aug 11, 2020
Merged

Allow $schemas in codegen #346

merged 10 commits into from
Aug 11, 2020

Conversation

leipzig
Copy link
Contributor

@leipzig leipzig commented Aug 11, 2020

This addresses #345
$schemas should be accepted and added to the loadingOptions

@mr-c
Copy link
Member

mr-c commented Aug 11, 2020

FYI @leipzig , you might benefit from make format after you pip install black (if needed)

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #346 into main will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   69.67%   69.74%   +0.07%     
==========================================
  Files          16       16              
  Lines        2846     2846              
  Branches      745      745              
==========================================
+ Hits         1983     1985       +2     
  Misses        677      677              
+ Partials      186      184       -2     
Impacted Files Coverage Δ
schema_salad/python_codegen.py 98.55% <ø> (ø)
schema_salad/ref_resolver.py 84.25% <0.00%> (+0.14%) ⬆️
schema_salad/fetcher.py 71.73% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb0956...207e334. Read the comment docs.

@mr-c mr-c merged commit 631a835 into common-workflow-language:main Aug 11, 2020
@mr-c
Copy link
Member

mr-c commented Aug 11, 2020

Thank you @leipzig !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants