Class vocab #412
Merged
Class vocab #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the vocabulary to map a short name like "CommandLineTool" to the fully qualified (avro) class name "w3id.org.cwl.cwl.CommandLineTool"
Codecov Report
@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 78.45% 78.54% +0.09%
==========================================
Files 18 18
Lines 3245 3254 +9
Branches 876 879 +3
==========================================
+ Hits 2546 2556 +10
+ Misses 460 459 -1
Partials 239 239
Continue to review full report at Codecov.
|
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
mr-c
reviewed
Jun 27, 2021
| @@ -98,7 +98,7 @@ | |||
|
|
|||
| setup( | |||
| name="schema-salad", | |||
| version="8.0", # update the VERSION prefix in the Makefile as well 🙂 | |||
| version="8.1", # update the VERSION prefix in the Makefile as well 🙂 | |||
There was a problem hiding this comment.
As the comment says, please update the VERSION prefix in the Makefile as well!
mr-c
reviewed
Jun 27, 2021
| @@ -87,6 +127,9 @@ def validate_ex( | |||
| if not foreign_properties: | |||
| foreign_properties = set() | |||
|
|
|||
| if vocab is None: | |||
| raise Exception("vocab must be provided") | |||
There was a problem hiding this comment.
Then why is vocab typed as Optional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.