dlang: fix mis-annotated link annotation #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-tan
added a commit
to common-workflow-lab/cwl-d-auto
that referenced
this pull request
Nov 19, 2022
|
It may not be the correct fix if I misunderstand the spec (See #631 (comment)). |
Codecov Report
@@ Coverage Diff @@
## main #632 +/- ##
=======================================
Coverage 83.43% 83.44%
=======================================
Files 20 20
Lines 4039 4041 +2
Branches 1096 1097 +1
=======================================
+ Hits 3370 3372 +2
Misses 426 426
Partials 243 243
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tom-tan
force-pushed
the
dlang-fix-_type-id
branch
from
c8bb954 to
a1d9f04
Compare
|
As clarified in #631 (comment) and #633, I introduced a new parameter for The resulted parser will work with schema-salad-d v0.11.0. |
|
Once #633 is merged, it is ready to merge! |
mr-c
force-pushed
the
dlang-fix-_type-id
branch
from
a1d9f04 to
92542d7
Compare
mr-c
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request fixes
@linkannotation in dlang codegen.Current implementation considers only the case of
_type: @idto add an annotation@linkbutidentity: trueis also needed as reported in #631.