Avoid mypy error on adding newGraph from cache to graph

[mvdbeek]

Fixes:

gxformat2/schema/v19_09.py:167: error: Argument 1 to "__iadd__" of "Graph" has incompatible type "Union[str, Graph, bool]"; expected "Iterable[Tuple[Node, Node, Node]]"  [arg-type]

and should also be a little more helpful when the external schema can't be parsed or fetched (not familiar with the code base, but isn't there a need to be more transparent about this??).

[mvdbeek]

As a sidenote,

schema_salad/schema_salad/tests/test_real_cwl/bio-cwl-tools/bamtools_stats.cwl

Line 130 in 8b8fe0b

- http://schema.org/version/9.0/schemaorg-current-http.rdf

does not exist currently, not sure if this should cause a test failure or not. When I missed the try/except around the fetch 4 tests were failing.

[mr-c]

As a sidenote,

schema_salad/schema_salad/tests/test_real_cwl/bio-cwl-tools/bamtools_stats.cwl

Line 130 in 8b8fe0b

- http://schema.org/version/9.0/schemaorg-current-http.rdf

does not exist currently, not sure if this should cause a test failure or not. When I missed the try/except around the fetch 4 tests were failing.

Heh, a useful "broken" test file then :-P
Lets rename the file and permanently break the URL
And refresh from https://github.com/common-workflow-library/bio-cwl-tools/blob/release/bamtools/bamtools_stats.cwl for the normal usage.

I'm torn about making the inability to resolve an external a failure or not

[mvdbeek]

I'm torn about making the inability to resolve an external a failure or not

Maybe something one could dispatch on with a --strict option or similar? Not suggesting this is high priority :).

[codecov]

Codecov Report

Merging #644 (94eaa5d) into main (dc57554) will increase coverage by 0.01%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   83.07%   83.09%   +0.01%     
==========================================
  Files          22       22              
  Lines        4478     4483       +5     
  Branches     1238     1238              
==========================================
+ Hits         3720     3725       +5     
- Misses        487      488       +1     
+ Partials      271      270       -1     

Impacted Files	Coverage Δ
schema_salad/ref_resolver.py	86.68% <73.68%> (+0.09%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[mr-c]

Thanks @mvdbeek !