Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make avro objects serializable & Pickle testing #660

Merged
merged 2 commits into from
Jan 28, 2023
Merged

make avro objects serializable & Pickle testing #660

merged 2 commits into from
Jan 28, 2023

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Jan 28, 2023

Fixes #659

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #660 (eecd6a9) into main (075d185) will increase coverage by 0.05%.
The diff coverage is 81.48%.

❗ Current head eecd6a9 differs from pull request most recent head 96c37cc. Consider uploading reports for the commit 96c37cc to get more accurate results

@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
+ Coverage   83.12%   83.18%   +0.05%     
==========================================
  Files          22       22              
  Lines        4487     4490       +3     
  Branches     1239     1239              
==========================================
+ Hits         3730     3735       +5     
+ Misses        487      486       -1     
+ Partials      270      269       -1     
Impacted Files Coverage Δ
schema_salad/codegen.py 94.59% <0.00%> (ø)
schema_salad/dotnet_codegen.py 95.77% <ø> (ø)
schema_salad/makedoc.py 84.75% <0.00%> (ø)
schema_salad/schema.py 78.38% <0.00%> (ø)
schema_salad/avro/schema.py 68.31% <90.90%> (+0.86%) ⬆️
schema_salad/cpp_codegen.py 78.81% <100.00%> (ø)
schema_salad/dlang_codegen.py 84.17% <100.00%> (ø)
schema_salad/fetcher.py 63.96% <100.00%> (ø)
schema_salad/java_codegen.py 91.10% <100.00%> (ø)
schema_salad/python_codegen.py 93.40% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mr-c mr-c enabled auto-merge (rebase) January 28, 2023 16:53
@mr-c mr-c merged commit 6bec6d4 into main Jan 28, 2023
@mr-c mr-c deleted the pickle_testing branch January 28, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: schema_salad.avro.schema.RecordSchema can be pickled, but cannot be unpickled
1 participant