fixes #805 The value of copyFrom.fetcher is not used in the LoadingOp… #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
=======================================
Coverage 83.35% 83.35%
=======================================
Files 22 22
Lines 4818 4818
Branches 1303 1303
=======================================
Hits 4016 4016
Misses 527 527
Partials 275 275 ☔ View full report in Codecov by Sentry. |
mr-c
approved these changes
Apr 10, 2024
…ot used in the LoadingOptions constructor in typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LoadingOptions.fetcher must be the same as the fetcher specified in the constructor's copyFrom, but it is not.
Initially, the value of copyFrom.fetcher is set to this.fetcher, but it is always overwritten later by the fetcher specified in the arguments or by DefaultFetcher.
I have corrected this by setting copyFrom.fetcher to fetcher instead of this.fetcher.