Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++23: ~heap_object() with incomplete types #852

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

eseiler
Copy link
Contributor

@eseiler eseiler commented Jul 26, 2024

No description provided.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.03%. Comparing base (77b3ebd) to head (80bd587).
Report is 44 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #852   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files          22       22           
  Lines        4833     4834    +1     
  Branches     1310     1310           
=======================================
+ Hits         4013     4014    +1     
  Misses        545      545           
  Partials      275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fascinating! Thank you

@mergify mergify bot merged commit 6416a95 into common-workflow-language:main Jul 26, 2024
44 checks passed
@eseiler eseiler deleted the fix/cpp23 branch July 26, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants