Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of user guide issues #5

Open
4 of 15 tasks
mr-c opened this issue Jul 12, 2017 · 2 comments
Open
4 of 15 tasks

List of user guide issues #5

mr-c opened this issue Jul 12, 2017 · 2 comments

Comments

@mr-c
Copy link
Member

mr-c commented Jul 12, 2017

This was referenced Jul 13, 2017
@evan-wehi
Copy link

evan-wehi commented Aug 2, 2017

I think even before getting into syntax details the user guide needs to give a much better conceptual description of the CWL objects and in general terms how they might be constructed and manipulated. Then the logic behind why CWL is the way is will be much clearer and will help people like me solve specific problems. For example, I hit the common issue that bam indexes need to travel along side the bam files even though the tools don't explicitly reference them. I found the solution on biostars (I think). This is it:

  #
  # Gather human bam and index into one dependency
  #
  gather:
    run:
      class: ExpressionTool

      inputs:
        bamFile:
          type: File
        bamIndex:
          type: File

      outputs:
        combined:
          type: File

      expression: >
        ${
          var ret = inputs.bamFile;
          ret["secondaryFiles"] = [
            inputs.bamIndex
          ];
          return {"combined" : ret};
        }

    in:
      bamFile:
        source: sort-human/sorted
      bamIndex:
        source: index-human/index

    out: [combined]

This does makes no sense to me. It seems to be javascript manipulating an internal CWL object. Without a model of what's going in CWL not only do I not understand this but I have no way to solve similar issues (of which there are many).

CWL is very rich, the user guide also needs much more coverage of its features. In particular, what can be done with JS needs more coverage. (Please bear in mind, some people are allergic to JS.)

@tobyhodges
Copy link
Contributor

Thanks @evan-wehi this is a good point. And I agree completely about the need for more coverage of features in general.

I'm nearly done with the more functional aspects of migrating the gentle intro material, at which point I hope that we can quickly begin to add additional sections and flesh out what is there already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants