Removed hard-coded .length case

Enable type checker to correctly type non-standard length properties. Fixes issue facebook#131.
commonlisp · Jan 21, 2015 · 5483abd · 5483abd
1 parent 0de91ac
commit 5483abd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/typing/flow_js.ml b/src/typing/flow_js.ml
@@ -1262,9 +1262,6 @@ let rec flow cx (l,u) trace =
  | (_,
  (GetT(_,"toLocaleString",_) | SetT(_,"toLocaleString",_))) -> ()
 
- | ((ObjT _ | ArrT _), GetT(reason_op,"length",tout)) ->
- unit_flow cx (NumT.why reason_op, tout)
-
  | ((ObjT _ | ArrT _),
  (SetT(_,"length",_) | MethodT(_,"length",_,_,_,_))) -> ()
 

diff --git a/tests/misc/F.js b/tests/misc/F.js
@@ -0,0 +1,2 @@
+function fn2(x) { return x.length * 4; }
+fn2({length: 'hi'}); 
diff --git a/tests/misc/misc.exp b/tests/misc/misc.exp
@@ -11,4 +11,8 @@ E.js:8:6,10: boolean
 This type is incompatible with
  E.js:4:14,19: number
 
-Found 3 errors
+F.js:2:14,17: string
+This type is incompatible with
+ F.js:1:26,37: number
+
+Found 4 errors