Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "-rdynamic" flag for static builds #300

Merged
merged 7 commits into from
May 29, 2019
Merged

Remove "-rdynamic" flag for static builds #300

merged 7 commits into from
May 29, 2019

Commits on May 25, 2019

  1. Configuration menu
    Copy the full SHA
    35b7e29 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2019

  1. Changed conditional to check for Linux

    At the time of this writing, it seems that CMake only uses "-rdynamic"
    on Linux:
    
    ```
    $ git clone https://github.com/Kitware/CMake.git
    Cloning into 'CMake'...
    remote: Enumerating objects: 335, done.
    remote: Counting objects: 100% (335/335), done.
    remote: Compressing objects: 100% (254/254), done.
    remote: Total 272793 (delta 86), reused 125 (delta 79), pack-reused 272458
    Receiving objects: 100% (272793/272793), 88.11 MiB | 29.21 MiB/s, done.
    Resolving deltas: 100% (207174/207174), done.
    $ cd CMake/Modules/
    Modules$ fgrep -r -w rdynamic .
    ./Platform/Linux-TinyCC-C.cmake:set(CMAKE_EXE_EXPORTS_C_FLAG "-rdynamic ")
    ./Platform/Linux-NAG-Fortran.cmake:set(CMAKE_SHARED_LIBRARY_LINK_Fortran_FLAGS "-Wl,-rdynamic")
    ./Platform/Linux-Intel.cmake:  set(CMAKE_SHARED_LIBRARY_LINK_${lang}_FLAGS "-rdynamic")
    ./Platform/Linux-GNU.cmake:  set(CMAKE_SHARED_LIBRARY_LINK_${lang}_FLAGS "-rdynamic")
    ```
    
    So the conditional has been modified accordingly.
    ericpruitt authored May 27, 2019
    Configuration menu
    Copy the full SHA
    b674bec View commit details
    Browse the repository at this point in the history
  2. Correct typo

    Fix typo by changing "STATIC" to "CMARK_STATIC".
    ericpruitt authored May 27, 2019
    Configuration menu
    Copy the full SHA
    1c7e0a6 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. Fix condition; "LINUX" is not a valid variable

    LINUX is not a CMake platform variable, so the expression has been
    updated accordingly and the build functionality verified.
    ericpruitt authored May 28, 2019
    Configuration menu
    Copy the full SHA
    ac6eef0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8675a4 View commit details
    Browse the repository at this point in the history
  3. Remove check for Linux

    ericpruitt authored May 28, 2019
    Configuration menu
    Copy the full SHA
    c6f5457 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Configuration menu
    Copy the full SHA
    b64eefd View commit details
    Browse the repository at this point in the history