-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commonmark-ext-gfm-tables single column table #7
Comments
Confirmed, definitely a bug. Looks like this is the minimal syntax for a single column:
|
Unfortunately the specification of the table is not clear for edge cases https://help.github.com/articles/github-flavored-markdown/#tables As I read the specification your example would be valid (minimal) tables. So would be an example where the vertical bar would be on the right. |
Yeah, it doesn't really have a spec :). But you can try the syntax using the Preview in comments here. What I'm not happy about with the above example is that in CommonMark, it's a setext header. And extensions should try to avoid changing existing block-level syntax. I'm thinking of requiring at least one pipe for the separator line, e.g. these would be tables:
And your original example as well. Thoughts? I have a patch that implements this, I'll push it soon. |
Contrary to what GitHub does, the following is not turned into a table: |Header --- Because we require the separator line to have at least one pipe in it (either at the start or the end or between columns). Otherwise it conflicts with a setext heading. If this turns out to be a problem, we can always revisit this.
Fixed as described above. I'll release this soon. |
Released in 0.2.0. |
Thanks a lot! |
Would expect to be able to render a single column table. Following code does not render a table.
The text was updated successfully, but these errors were encountered: