-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing period prevents links within emphasis #317
Comments
I ran those strings through Babelmark2 and am seeing similar results. |
Actually, it looks the issue occurs regardless of which punctuation character appears at the end. Could this be a bug where the ending |
See commonmark/commonmark.js#12 - this is the same issue, I believe, and a solution is sketched out there. I mean to give this some further thought, but will probably implement what is described there. Comments welcome. |
I think, that's implementation bug in markdown-it: markdown-it/markdown-it#97 Spec looks good for me with last commits. |
Tests missed. Example with link needed in spec. |
This change mirrors commonmark/commonmark.js@0b40889 Additional information: - commonmark/commonmark-spec#310 - commonmark/commonmark-spec#317 - commonmark/commonmark.js#12
This change mirrors commonmark/commonmark.js@0b40889 Additional information: - commonmark/commonmark-spec#310 - commonmark/commonmark-spec#317 - commonmark/commonmark.js#12
Re-opened here from markdown-it #94. As was pointed out to me by @rlidwka, this seems to be broken in the dingus as well, despite what I initially thought below. As per @rlidwka, it appears the trailing period is causing the confusion.
I'm seeing a bug wherein a link within an emphasis/bold block is not showing as
strong
.Example:
I would have expected:
You'll note that this works as expected when the link is not included:
This seems to work as I expected on the Commonmark Dingus.
If this user error, my utmost apologies; please let me know what I'm doing wrong!
The text was updated successfully, but these errors were encountered: