Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LLVM -fno-exceptions flag #1

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

hakonhagland
Copy link

Remove the LLVM -fno-exceptions flag from the COMPILE_FLAGS property of the smokegen target. This fixes commonqt/commonqt5#4.

Remove the LLVM -fno-exceptions flag from the COMPILE_FLAGS
property of the smokegen target. This fixes commonqt5, issue #4.
@luismbo
Copy link

luismbo commented Mar 8, 2022

First off, many thanks for looking into getting this up and running on Linux.

Can you add some comments around the CMake directives you're adding explaining what's going on. Everyone else around here is fairly clueless about CMake and C++. :)

@hakonhagland
Copy link
Author

@luismbo Thanks, I am trying to get a Perl module working for Qt5. I am not familiar with Common Lisp :). The Perl module seems to be abandoned 2 years ago. There is a Qt4 version on CPAN but not a version for Qt5. I thought it would be a fun project to try upgrade it to Qt5 and learn more about Qt :) If you would like to join the project (e.g. to learn Perl) it would be great!

First I found out that the Perl bindings depended on SMOKE bindings, but the generator library did not compile and the author seemed to have abandoned the project. I observed that there were a couple of forks to the repository and further googling led me here to Common Qt5!

Regarding this PR, I am not so familiar with cmake myself, so I first asked this question and later found the answer myself by trial and error. I am still not sure why LLVM adds this -fno-exceptions flag, but for now I am just focusing on making things compile. Let me know if this clarifies things a little bit?

@luismbo luismbo merged commit 8f88d33 into commonqt:clang Mar 9, 2022
@luismbo
Copy link

luismbo commented Mar 9, 2022

@hakonhagland yeah, thanks for your clarification. Merged. Let me know if you'd like to open a smokegen repository somewhere more canonical-looking. I think it'd be a shame to have each set of language-specific bindings maintain diverging versions of smokegen and smokeqt since the manpower is streched so thin as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to build smokegen on Linux?
2 participants