(fixes #2872) Refactoring unused files for "showcase view whole nearby activity" #5870
Conversation
app/src/main/res/values/strings.xml
Outdated
| @@ -303,7 +303,7 @@ | |||
|
|
|||
| <string name="about_translate_cancel">Cancel</string> | |||
| <string name="retry">Retry</string> | |||
| <string name="showcase_view_whole_nearby_activity">These are the places near you that need pictures to illustrate their Wikipedia articles.\n\nClicking on \'SEARCH THIS AREA\' locks the map and launches a nearby search around that location.</string> | |||
| <string name="showcase_view_whole_nearby_activity">These are the places near you that need pictures to illustrate their Wikipedia articles.\n\nClicking on \'Search this area\' locks the map and launches a nearby search around that location.</string> | |||
There was a problem hiding this comment.
There is no "Search this area" button anymore.
Actually, is this string used somewhere? If you find where it is used, would you mind posting a screenshot?
Thanks a lot! 🙂
There was a problem hiding this comment.
I found that it was used in dialog_nearby.xml, but I believe the activity using the layout has been refactored.
There was a problem hiding this comment.
Would you mind trying to remove it? Any impact? 🙂
There was a problem hiding this comment.
Deleting the button and its string seems fine
There was a problem hiding this comment.
Hey Nicholas after further review I noticed that the dialog_nearby.xml file had no usages in the whole app. I’ve safely deleted the file along with its associated string resources, and the project still builds without issues.
It seems the file was part of the old webview in the nearby section of the contributions activity, likely from a version of the app prior to refactoring.
| @@ -62,6 +62,7 @@ | |||
| android:padding="@dimen/activity_margin_horizontal" | |||
| android:singleLine="true" | |||
| android:text="@string/search_this_area" | |||
| android:textAllCaps="false" | |||
There was a problem hiding this comment.
What is the problem if you don't add this line?
There was a problem hiding this comment.
The line was initially included to ensure that the button text aligned with the original TextView string (which has now been removed) as Android Studio defaults buttons to AllCaps. However, since we are removing it, it may no longer be necessary.
There was a problem hiding this comment.
How about removing this whole button?
There was a problem hiding this comment.
While the TextView that used to prompt users to use this button has been refactored and removed, the button remains in the app and is still used in the Map Explore activity, as shown below 
There was a problem hiding this comment.
Do you know what makes the text become uppercase in the first place?
We should fix the root issue rather than address this single symptom.
Would you mind checking whether these are really needed?
app/src//main/res/layout-land/activity_review.xml: android:textAllCaps="true"
app/src//main/res/layout/bottom_sheet_details_explore.xml: android:textAllCaps="true"
app/src//main/res/layout/bottom_sheet_details_explore.xml: android:textAllCaps="true"
app/src//main/res/layout/bottom_sheet_details_explore.xml: android:textAllCaps="true"
app/src//main/res/layout/fragment_achievements.xml: android:textAllCaps="true"/>
app/src//main/res/layout/fragment_achievements.xml: android:textAllCaps="true"/>
app/src//main/res/layout/custom_nearby_tab_layout.xml: android:textAllCaps="true"
app/src//main/res/layout/activity_review.xml: android:textAllCaps="true"
app/src//main/res/layout/fragment_review_image.xml: android:textAllCaps="true"
app/src//main/res/layout/fragment_review_image.xml: android:textAllCaps="true"
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
devbytespark
changed the title
| @@ -62,6 +62,7 @@ | |||
| android:padding="@dimen/activity_margin_horizontal" | |||
| android:singleLine="true" | |||
| android:text="@string/search_this_area" | |||
| android:textAllCaps="false" | |||
There was a problem hiding this comment.
Do you know what makes the text become uppercase in the first place?
We should fix the root issue rather than address this single symptom.
Would you mind checking whether these are really needed?
app/src//main/res/layout-land/activity_review.xml: android:textAllCaps="true"
app/src//main/res/layout/bottom_sheet_details_explore.xml: android:textAllCaps="true"
app/src//main/res/layout/bottom_sheet_details_explore.xml: android:textAllCaps="true"
app/src//main/res/layout/bottom_sheet_details_explore.xml: android:textAllCaps="true"
app/src//main/res/layout/fragment_achievements.xml: android:textAllCaps="true"/>
app/src//main/res/layout/fragment_achievements.xml: android:textAllCaps="true"/>
app/src//main/res/layout/custom_nearby_tab_layout.xml: android:textAllCaps="true"
app/src//main/res/layout/activity_review.xml: android:textAllCaps="true"
app/src//main/res/layout/fragment_review_image.xml: android:textAllCaps="true"
app/src//main/res/layout/fragment_review_image.xml: android:textAllCaps="true"
Description (required)
The refactored showcase nearby activity previously relied on a hardcoded string located in this file. This resulted in some inconsistency between the two activities.
Fixes #2872
What changes did you make and why?
While the best approach would be to parameterize the string with the key showcase_view_whole_nearby_activity to ensure consistency, the activity that previously utilized that layout has been removed. Consequently, the initial approach with the following pseudo-code is no longer applicable:
Parameterise the showcase string
Set the showcase string to use the search_this_area string
As a temporary workaround, I have edited the hardcoded string to ensure it aligns with the expected output from the search_this_area string and disabled the automatic capitalization flag in the button for consistency.
Tests performed (required)
Tested on ProdDebug on Pixel 9 with API level 34 to ensure consistency with the capitalization as shown in the following two screenshots.
Before the change:
After the change:
