Migrated Custom Image Selector to Jetpack Compose #5964
Conversation
Also, refactor the UI components
|
I know it is a draft, but I could not resist trying 😊 I get this when coming from a previous version of the app: After deleting the app's data it opens fine. When I select a pic and tap "Upload" or "Mark as not for upload", nothing happens. I see no "Show already actioned images" switch. After long-pressing a picture, I can not swipe it up (select for upload) or down (mark as not for upload). |
|
Thank you @nicolas-raoul for your valuable feedback 😊 |
| MediaStore.Images.Media.DATE_ADDED, | ||
| MediaStore.Images.Media.MIME_TYPE | ||
| ) | ||
| val cursor = context.contentResolver.query( |
There was a problem hiding this comment.
Can you add a // TODO: comment - we also use Room in the app, and it supports returning a Flow from a query. Eventually migrating this query to Room and returning the Flow directly would simplify this code, and for now, a TODO comment will serve as a nice breadcrumb trail toward a better overall architecture.
There was a problem hiding this comment.
Thanks for reviewing @psh. I doubt how Room can help fetch images from phone storage.
app/src/main/java/fr/free/nrw/commons/customselector/ui/screens/ViewImageScreen.kt
Show resolved
Hide resolved
Description (required)
Fixes #5963
What changes did you make and why?
I've created the UI for the Custom Image Selector with some minor UI changes. We can't upload from Custom Selector as I am still working on it. Please feel free to test this branch on your device and let me know your thoughts. I am open to suggestions on the UI and functionality.
Tests performed (required)
Tested ProdDebug on Samsung A14 with API level 34.
Screenshots (for UI changes only)