Code Enhancement (Explore Map) #6293
Conversation
| @@ -717,8 +717,17 @@ private void addMarkerToMap(BaseMarker nearbyBaseMarker) { | |||
| authorUser = Html.fromHtml(authorUser, Html.FROM_HTML_MODE_LEGACY).toString(); | |||
| } | |||
|
|
|||
| OverlayItem item = new OverlayItem(nearbyBaseMarker.getPlace().name, | |||
| authorUser, point); | |||
| String title = nearbyBaseMarker.getPlace().name; | |||
There was a problem hiding this comment.
Does getPlace() have something like .caption or .label? That would be better, though that can be split to a different issue.
There was a problem hiding this comment.
getLabel() is causing some issue and there is nothing like .caption
There was a problem hiding this comment.
The app is getting crashed
| } | ||
| title = title.replaceAll("(?i)\\.(jpg|jpeg|png|svg)$", ""); | ||
| title = title.replace("_", " "); | ||
| if (title.length() >43) { |
There was a problem hiding this comment.
Would you mind adding a comment explaining why truncating is necessary? Thanks!
There was a problem hiding this comment.
we are truncating because the title doesn't fits in the box
There was a problem hiding this comment.
Yes, please add this info as a code comment // so that future readers will know why. :-)
There was a problem hiding this comment.
I hope this works
|
✅ Generated APK variants! |
* Exclude past locations (P585) from Nearby query * "Send" button text should be white * Custom picker: logic * Revert back changes * Enhancement :- Explore Map information * Enhancement :- Explore Map information * Style --------- Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
Description (required)
Fixes #6266
What changes did you make and why?
Tests performed (required)
Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.
Tested {build variant :-betaDebug} on {OnePlus Nord CE4 Lite} with API level {35}.
Screenshots (for UI changes only)